This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Use non-deployment-interacting KillService during kill-and-wipe #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Expunge caused a deployment, which caused MarathonSchedulerActor to lock for the app. This led to the subsequent kill request to MarathonSchedulerActor to fail. Fixes #5155 Backport of 560ba8b Test Plan: sbt test Reviewers: aquamatthias, meichstedt, jenkins Subscribers: marathon-team Differential Revision: https://phabricator.mesosphere.com/D548
meichstedt
approved these changes
Feb 23, 2017
timcharper
deleted the
tharper/backport-1.4-use-non-deployment-kill-service-for-wipe
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Expunge caused a deployment, which caused MarathonSchedulerActor to lock
for the app. This led to the subsequent kill request to
MarathonSchedulerActor to fail.
Fixes #5155
Backport of 560ba8b
Test Plan: sbt test
Reviewers: aquamatthias, meichstedt, jenkins
Subscribers: marathon-team
Differential Revision: https://phabricator.mesosphere.com/D548