This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Read LaunchedOnReservation and Reserved tasks #5243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, all tasks were being read as LaunchedEphemeral task subtypes, and this was leading to any resident information about the task to be lost. This change fixes the issue, and adds round-trip serialization tests. Fixed #5165 Backport of dad4e1f Test Plan: unit Reviewers: aquamatthias, meichstedt Subscribers: marathon-team Differential Revision: https://phabricator.mesosphere.com/D546
|
retest this please |
jasongilanfarr
approved these changes
Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, all tasks were being read as LaunchedEphemeral task
subtypes, and this was leading to any resident information about the
task to be lost.
This change fixes the issue, and adds round-trip serialization tests.
Fixed #5165
Backport of dad4e1f
Test Plan: unit
Reviewers: aquamatthias, meichstedt
Subscribers: marathon-team
Differential Revision: https://phabricator.mesosphere.com/D546