This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Backport: Don't destroy persistent volumes when killing unreachable resident tasks #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meichstedt
approved these changes
Mar 6, 2017
unterstein
approved these changes
Mar 8, 2017
Summary: Killing an unreachable resident task will do nothing, rather than destroy the reservations. Fixes #5207 Also-By: tharper@mesosphere.com Test Plan: sbt test Reviewers: unterstein, meichstedt, jasongilanfarr, jenkins Reviewed By: meichstedt, jasongilanfarr, jenkins Subscribers: jdef, marathon-team Differential Revision: https://phabricator.mesosphere.com/D529
timcharper
force-pushed
the
tharper/backport-d529-dont-destroy-unreachable-persistent-vols
branch
from
fec2729 to
1455fdd
Compare
timcharper
deleted the
tharper/backport-d529-dont-destroy-unreachable-persistent-vols
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Killing an unreachable resident task will do nothing, rather than
destroy the reservations.
Fixes #5207
Also-By: tharper@mesosphere.com
Test Plan: sbt test
Reviewers: unterstein, meichstedt, jasongilanfarr, jenkins
Reviewed By: meichstedt, jasongilanfarr, jenkins
Subscribers: jdef, marathon-team
Differential Revision: https://phabricator.mesosphere.com/D529