Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

DCOS-13710: Unleash prettier #402

Merged
merged 4 commits into from
May 2, 2017
Merged

Conversation

mlunoe
Copy link
Contributor

@mlunoe mlunoe commented Apr 27, 2017

NO MERCY

144425-3530-smyhr-a

Review commit by commit ignoring: style(Prettier): correct styles of all files

mesosphere-backup/javascript#2
mesosphere-backup/javascript#1
dcos/dcos-ui#2008

Copy link
Contributor

@nLight nLight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@weblancaster
Copy link
Contributor

the code looks good but when trying to run npm run dist this what I get (before that I cleaned node_modules and re-install them).

screen shot 2017-05-02 at 10 09 09 am

@mlunoe
Copy link
Contributor Author

mlunoe commented May 2, 2017

Good catch! Fixed the issue!

Copy link
Contributor

@weblancaster weblancaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖

@weblancaster weblancaster merged commit 65835cc into master May 2, 2017
@weblancaster weblancaster deleted the mlunoe/unleash-prettier branch May 2, 2017 20:01
mlunoe added a commit to dcos/dcos-ui that referenced this pull request May 2, 2017
Poltergeist pushed a commit to dcos/dcos-ui that referenced this pull request May 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants