upgrade to delaunator@4 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #50 removes delaunay.outedges from the API, replaced with the private _hullIndex
This was referenced May 24, 2019
Closed
mourner
approved these changes
May 24, 2019
|
@Fil let's merge then? Or did you plan to get the degenerate cases handling into the same major version? |
|
Depends on your feedback on mapbox/delaunator#47 ; if negative, then we can merge this and find a better way to solve #64. If positive, then we can make a more interesting major version. |
|
@Fil that one is merged, but I'm thinking of also merging in mapbox/delaunator#48 to cram this into a semver major too, and then we can release new major versions of both |
|
Yes let's move forward with everything |
|
Superseded by #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50
removes delaunay.outedges from the API, replaced with the private _hullIndex