Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force radial x y accessors #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Force radial x y accessors #176

wants to merge 2 commits into from

Commits on Aug 13, 2020

  1. Passing functions to radial.x() and radial.y() 

    Currently, the radial force...

    d3.forceRadial(radius[, x][, y])

... allows only numbers to the `x` and `y` positions:

> If x is specified, sets the x-coordinate of the circle center to the specified number and returns this force.

This proposed change allows passing functions to `radial.x()` and `radial.y()`, using the same pattern of other forces. Here is the working demo: https://bl.ocks.org/anonymous/0685343afe4675a022403be8728bc7c4/7dda06727201c128b9ff820b24c2c955e655436d
    @GerardoFurtado @Fil
    GerardoFurtado authored and Fil committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    5b899e4 View commit details
    Browse the repository at this point in the history

  2. document forceRadial.x() and .y() as setting accessor functions inste… 

    …ad of numbers
    @Fil
    Fil committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    199f124 View commit details
    Browse the repository at this point in the history