Fixed a precision problem with large values in packEnclose #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test showing how
packEncloseis failing with thex,yvalues above1e5. It runs out of precision and throws anErrorat line 46 during the front propagation.I've added translation of the circles to
encloseBasis3, so that the overall values are smaller.The time complexity is intact. I had to update the expected result in the edge case test (precision change).
Thank you for the wonderful algorithm implementation!
Example