Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for unlimiter outer padding in band scale. Fixes #102. #101

Closed
wants to merge 1 commit into from
Closed

Allow for unlimiter outer padding in band scale. Fixes #102. #101

wants to merge 1 commit into from

Conversation

hhrogersii
Copy link

  • removes the clipping of outer padding values > 1.

@hhrogersii hhrogersii mentioned this pull request Apr 27, 2017
Closed
@hhrogersii hhrogersii changed the title Allow for unlimiter outer padding in band scale. Fixes #101. Allow for unlimiter outer padding in band scale. Fixes #102. Apr 27, 2017
@mbostock
Copy link
Member

  • Can you also make the corresponding change to point scales?

  • Can you augment the test for band.paddingOuter so that it verifies the correct behavior when the outer padding is greater than 1 (say, 2)? You can add a few lines to this existing test.

mbostock added a commit that referenced this pull request Jan 26, 2019
@mbostock
Allow unlimited outer padding.
fb5f0b3 
Also clarify the documentation for outer padding.

Fixes #101.
Fixes #102.
Fixes #132.
@mbostock
Copy link
Member

Folded into #156, and added documentation. Will be released in d3-scale 2.2.

@mbostock mbostock closed this Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhrogersii @mbostock