Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt type=module #246

Merged
merged 11 commits into from
Jun 5, 2021
Merged

Adopt type=module #246

merged 11 commits into from
Jun 5, 2021

Conversation

Fil
Copy link
Member

@Fil Fil commented Apr 27, 2021 •
edited by mbostock
Loading

follow changes in d3-format:

  • type=module
  • add exports
  • remove zip
  • license: ISC
  • update dependencies

TODO:

  • update README.md
  • check LICENSE
  • fix failing tests
  • depends on several other d3 modules (see package.json)
  • switch the default branch to main

@Fil
Adopt type=module
51e5a09 
follow changes in d3-format:
* type=module
* add exports
* remove zip
* license: ISC
* update dependencies
@Fil Fil requested a review from mbostock April 27, 2021 08:24
@Fil Fil mentioned this pull request Apr 28, 2021
Closed
@mbostock mbostock mentioned this pull request Jun 4, 2021
Closed
35 tasks
@mbostock
Copy link
Member

mbostock commented Jun 5, 2021

We should have fixed the hyphen-minus…

@mbostock mbostock marked this pull request as ready for review June 5, 2021 19:55
@mbostock mbostock merged commit ac30873 into main Jun 5, 2021
@mbostock mbostock deleted the fil/type-module branch June 5, 2021 19:55
@sabitha-kuppusamy sabitha-kuppusamy mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock