Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where solo aspect wasn't correctly parsed #14

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fixed a bug where solo aspect wasn't correctly parsed #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69afbd1
Fixed a bug where solo aspect wasn't correctly parsed
tdavidovicNV Nov 3, 2023
3bca9e3
Further cleanup of the non-array aspects
tdavidovicNV Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/item/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ def should_keep(item: Item):

if item.aspect and filter_aspects is not None:
for filter_data in filter_aspects:
filter_aspect = [filter_data] if isinstance(filter_data, str) else filter_data
aspect_name, *rest = aspect if isinstance(filter_aspect, list) else [filter_aspect]
aspect_name, *rest = filter_data if isinstance(filter_data, list) else [filter_data]
threshold = rest[0] if rest else None
condition = rest[1] if len(rest) > 1 else "larger"

Expand Down