-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/added all aspects with numbers in pos1 and 2 #29
Merged
aeon0
merged 17 commits into
d4lfteam:main
from
tomas-davidovic:dev/added_all_aspects_with_numbers_in_pos1_and_2
Nov 5, 2023
Merged
Dev/added all aspects with numbers in pos1 and 2 #29
aeon0
merged 17 commits into
d4lfteam:main
from
tomas-davidovic:dev/added_all_aspects_with_numbers_in_pos1_and_2
Nov 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…number on a second position
…entalists_aspect_variable_number_second' and 'fix/incorrectly_parsed_aspects'
Added Bow and Crossbow to the doublehanded weapons Co-authored-by: Jo <aeon4@pm.me>
…et -> reported 22)
…ithub.com/tomas-davidovic/d4lf into dev/adjust_aspect_value_base_on_item_type
…ncorrectly_parsed_aspects'
Another aspect with variable number in the second place
aeon0
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin, the position is based on the first variable number.