Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile editor gui #414

Closed
wants to merge 10 commits into from
Closed

Add profile editor gui #414

wants to merge 10 commits into from

Conversation

Shebour
Copy link

@Shebour Shebour commented Jan 26, 2025

I added a simple profile editor in the GUI as a new tab:

profile_editor_gui

  • You can only edit an already downloaded profile configuration.
  • You cannot add or delete items from the profile. It will be added in a future update if this one is accepted.
  • The default profile loaded is the first one in the params.ini file.
  • You can open a specific profile file to edit it.
  • You can set minPower, minCount, minGreaterAffixCount, affixes and inherent affixes.

@cjshrader
Copy link
Contributor

I am testing this out. Some notes:

Please make the drop down boxes ignore the scroll wheel. You can reuse what I did in the config tab:

class IgnoreScrollWheelComboBox(QComboBox):

Please add a reset button to reset back to the values in the file, if that is not too difficult.

Otherwise I think this is a great starter point, I already used it on some of my profiles. The set all * buttons are great.

@Shebour
Copy link
Author

Shebour commented Jan 31, 2025

  • Using ProfileModel to load/save profile yaml
  • Refresh button to reset all values from file
  • Create / Delete items
  • Fixing save alert when clicking Cancel, do not quit app.
  • Using IgnoreScrollWheelComboBox and IgnoreScrollWheelSpinBox for SpinBox

@cjshrader
Copy link
Contributor

This is looking good, I'm going to make some small tweaks to it in the main branch and make a release

@cjshrader
Copy link
Contributor

There are a lot of formatting changes needed. We use a tool called ruff for that. For future development, please install ruff: https://github.com/astral-sh/ruff

I have it set up in Intellij IDEA to run every time I save a file, which happens automatically all the time. I don't know what IDE you use but I bet you can do the same.

For now, I'm fixing these issues myself in this pr: #423

@cjshrader
Copy link
Contributor

This was now merged and I'll make a release soon. I'll be closing this PR. Good work!

@cjshrader cjshrader closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants