-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppImage build script #91
Conversation
I can confirm the appimage seems to be working fine in mint 20.1 |
Updated with metadata and icon files |
Hi @blipk and thanks for the contribution. That is awesome! You added the appimagetool-x86_64.AppImage to be already available for the build script. I would prefer to download it on demand if not already available. In that way you can be sure to use the latest version when building. My suggestion would be adding something like this before executing the appimagetool:
I would appreciate your opinion on this. |
Great idea @d4nj1 |
@d4nj1 is this able to be published on pip3? Might be better to try this if it is: https://docs.appimage.org/packaging-guide/converting-binary-packages/pkg2appimage.html#converting-python-applications-packaged-with-pip |
Latest version uses pkg2appimage that pulls tlp-ui from github and pulls dependencies from the debian/ubuntu respositories and packages them into the AppImage, this should work on any system as all the dependencies are there, working on my Manjaro install. Can be tested here: https://github.com/blipk/TLPUI/blob/master/build/AppImage/out/TLP_UI-x86_64.AppImage |
@d4nj1 let me know before you merge this, I will change the references in the YAML file to your repository |
Hi @blipk, |
No problem @d4nj1 have removed the file and updated the reference in the script to your github. |
Thanks again for your contribution! |
Works for me on latest version of Manjaro.
Needs more testing to find which libraries need to be added to TLPUI.AppDir/usr/lib