Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage build script #91

Merged
merged 10 commits into from
Apr 10, 2021
Merged

AppImage build script #91

merged 10 commits into from
Apr 10, 2021

Conversation

blipk
Copy link
Contributor

@blipk blipk commented Mar 22, 2021

Works for me on latest version of Manjaro.

Needs more testing to find which libraries need to be added to TLPUI.AppDir/usr/lib

@mjtueros
Copy link

mjtueros commented Mar 22, 2021

I can confirm the appimage seems to be working fine in mint 20.1

@blipk
Copy link
Contributor Author

blipk commented Mar 23, 2021

Updated with metadata and icon files

@d4nj1
Copy link
Owner

d4nj1 commented Mar 24, 2021

Hi @blipk and thanks for the contribution. That is awesome!
I have just one small thing to discuss before I would merge the PR.

You added the appimagetool-x86_64.AppImage to be already available for the build script. I would prefer to download it on demand if not already available. In that way you can be sure to use the latest version when building. My suggestion would be adding something like this before executing the appimagetool:

if [ ! -f appimagetool-x86_64.AppImage ]; then
    wget https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage
fi

I would appreciate your opinion on this.

@blipk
Copy link
Contributor Author

blipk commented Mar 25, 2021

Great idea @d4nj1
Have pushed an update which does that

@blipk
Copy link
Contributor Author

blipk commented Mar 25, 2021

@d4nj1 is this able to be published on pip3?

Might be better to try this if it is: https://docs.appimage.org/packaging-guide/converting-binary-packages/pkg2appimage.html#converting-python-applications-packaged-with-pip
Can set up a YAML file to run through pkg2appimage that downloads and packages everything.

@blipk
Copy link
Contributor Author

blipk commented Mar 25, 2021

Latest version uses pkg2appimage that pulls tlp-ui from github and pulls dependencies from the debian/ubuntu respositories and packages them into the AppImage, this should work on any system as all the dependencies are there, working on my Manjaro install.

Can be tested here: https://github.com/blipk/TLPUI/blob/master/build/AppImage/out/TLP_UI-x86_64.AppImage

@blipk
Copy link
Contributor Author

blipk commented Mar 26, 2021

@d4nj1 let me know before you merge this, I will change the references in the YAML file to your repository

@d4nj1
Copy link
Owner

d4nj1 commented Apr 7, 2021

Hi @blipk,
sorry for the late response. I just reviewed the last changes and everything seems fine from my point of view. The only thing that would be great is if you could remove the final build/AppImage/out/TLP_UI-x86_64.AppImage file from the PR. Then I would merge.

@blipk
Copy link
Contributor Author

blipk commented Apr 7, 2021

No problem @d4nj1 have removed the file and updated the reference in the script to your github.
Thanks.

@d4nj1 d4nj1 merged commit c2918f0 into d4nj1:master Apr 10, 2021
@d4nj1
Copy link
Owner

d4nj1 commented Apr 10, 2021

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants