Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection & filter for side-loaded apps #5

Closed
d4rken opened this issue Jul 16, 2022 · 11 comments
Closed

Detection & filter for side-loaded apps #5

d4rken opened this issue Jul 16, 2022 · 11 comments
Labels
enhancement New feature or request help/discussion wanted Extra attention is needed
Milestone

Comments

@d4rken
Copy link
Member

d4rken commented Jul 16, 2022

From #1 (comment)

See for installer packagenames: d4rken-org/sdmaid#5618

/cc @TheMysticS

@d4rken d4rken added the enhancement New feature or request label Jul 16, 2022
@d4rken d4rken changed the title Filter for sideloaded apps Detection & filter for side-loaded apps Jul 16, 2022
@d4rken
Copy link
Member Author

d4rken commented Jul 16, 2022

Basic detection (Google Play or not) is available since https://github.com/d4rken/mystic-permissions/releases/tag/v0.0.7

@d4rken d4rken added the help/discussion wanted Extra attention is needed label Jul 17, 2022
@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 17, 2022

vivo app store: com.vivo.appstore
oppo app store: com.oppo.market
Huawei app store: com.huawei.appmarket
Samsung app store: com.sec.android.app.samsungapps
Xiaomi app store: com.xiaomi.mipicks

@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 17, 2022

Hmm the app also detected that i installed this app via PC adb.
Screenshot_2022-07-17-23-59-03-90
This should renamed to "App installed via Computer, using Android Debug Bridge" or just "App installed via ADB"

@d4rken
Copy link
Member Author

d4rken commented Jul 17, 2022

Is that the official label? Do you have a link to documentation that says this?

@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 17, 2022

Is that the official label? Do you have a link to documentation that says this?

This is the Code you use to determine from what source the app installed right? Well i dont know if that's the official label when you install an app via adb (i think maybe this is different on other Android version?)

and other app manager seems catches it too and adds label "pc"
Screenshot_2022-07-18-00-56-18-57

@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 17, 2022

@d4rken
Copy link
Member Author

d4rken commented Jul 17, 2022

AFAIK installing via ADB does not automatically set a value, but it is null instead.
For your app, the name was set to pc by the installer, though I don't it was ADB, unless you added the option to set it like then when executing the adb install command.

I think the label here should be a default "Unknown installer (pc)".

This is the Code you use to determine from what source the app installed right? Well i dont know if that's the official label when you install an app via adb (i think maybe this is different on other Android version?)

This is a container class to later allow me to add more information easily. The detection itself currently happens here:

https://github.com/d4rken/mystic-permissions/blob/3c5352b9aeac1cb4308658a9018ce5c69f1aded0/app/src/main/java/eu/darken/myperm/apps/core/AppRepo.kt#L88-L117

PS:(Remove the ! from screenshots when not strictly necessary, to keep the thread easily scrollable.

d4rken added a commit that referenced this issue Jul 17, 2022
@d4rken
Copy link
Member Author

d4rken commented Jul 17, 2022

vivo app store: com.vivo.appstore oppo app store: com.oppo.market Huawei app store: com.huawei.appmarket Samsung app store: com.sec.android.app.samsungapps Xiaomi app store: com.xiaomi.mipicks

I've added these, see:
https://github.com/d4rken/mystic-permissions/blob/c5551253f7b35b572e9a2975f901fd6c025ad9ca/app/src/main/java/eu/darken/myperm/apps/core/known/ZKnownPkgs.kt#L14-L40

@d4rken
Copy link
Member Author

d4rken commented Jul 17, 2022

If sideloading detection itself is working ok, please close this, and for adding new app stores, we can make new tickets.

@dragonGod97677
Copy link
Contributor

If sideloading detection itself is working ok, please close this, and for adding new app stores, we can make new tickets.

Uh, you are the one created this XD

@dragonGod97677
Copy link
Contributor

PS:(Remove the ! from screenshots when not strictly necessary, to keep the thread easily scrollable.

Okay, sure 👍

@d4rken d4rken closed this as completed Jul 18, 2022
@d4rken d4rken added this to the v1.0.0 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help/discussion wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants