Abstract out Block and Field Formatters into submodules. #12
Conversation
doylejd
commented
Aug 12, 2015
doylejd
commented
- Abstracted out blocks and field formatters into their own modules.
- Added configuration settings to block to match AddThisBasicToolbox for more flexibility.
- Remove global addition of addthis_widget. Place it into render functions of fields/blocks.
…ded configuration settings to block to match AddThisBasicToolbox for more flexibility.
| @@ -24,8 +24,8 @@ function addthis_page_attachments(array &$page){ | |||
|
|
|||
| // Include the widget js when we include on all but admin pages. | |||
| //if (!path_is_admin(current_path()) && AddThis::getInstance()->getWidgetJsInclude() == AddThis::WIDGET_JS_INCLUDE_PAGE) { | |||
| $manager = \Drupal\addthis\Services\AddThisScriptManager::getInstance(); | |||
| $manager->attachJsToElement($page); | |||
| //$manager = \Drupal\addthis\Services\AddThisScriptManager::getInstance(); | |||
There was a problem hiding this comment.
I would remove this commented out code, it's versioned
There was a problem hiding this comment.
@nerdstein Should be updated in this PR.
| $form['settings']['addthis_settings']['type'] = array( | ||
| $form['settings']['addthis_settings']['share_services'] = array( | ||
| '#title' => t('Services'), | ||
| '#type' => 'textfield', |
There was a problem hiding this comment.
This is going to be pulled in as a checklist in a future PR?
There was a problem hiding this comment.
@nerdstein I want to get some more feedback on this since the interface for the checkboxes is so large. Providing a link to the options and textfield seems usable, but I agree that it is probably not the best approach.
I want to keep mobile editing in mind here - a list of 300 checkboxes might provide more problems.
There was a problem hiding this comment.
Might be a good first step and add an issue to improve the UX
|
This looks pretty good. i'd groom the readme just a bit more and i'll merge |
|
@nerdstein README updated. |
Abstract out Block and Field Formatters into submodules.
|
Merged |
