Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored services and element pattern #31

Merged
merged 2 commits into from
Aug 18, 2015
Merged

Refactored services and element pattern #31

merged 2 commits into from
Aug 18, 2015

Conversation

damontgomery
Copy link
Contributor

  • Most testing is done with the block system.
  • Started refactoring the element types to use one twig template per.
  • The javascript doesn't work currently and will be the next thing to look at.

@damontgomery
- Refactored services to use the services.yml pattern.
08da971 
- Most testing is done with the block system.
- Started refactoring the element types to use one twig template per.
- The javascript doesn't work currently and will be the next thing to look at.
@damontgomery
overhaul the Javascript
99b7c32 
Remove most of the JS for now and load the simplest case.
We may need to do the complex logic, but it wasn't clear what it was for.
Simplified AddThisScriptManager service for now to provide access to aggregated settings.
doylejd pushed a commit that referenced this pull request Aug 18, 2015
Merge pull request #31 from damontgomery/feature/services-refactor
94f4dd8 
@damontgomery  Thank's for the help cleaning up. Definitely some good patterns for us to follow. Merging this in.
@doylejd doylejd merged commit 94f4dd8 into d8-contrib-modules:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damontgomery @doylejd