Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Traits for Shared Partial Forms #37

Merged
merged 3 commits into from
Aug 20, 2015

Conversation

doylejd
Copy link
Contributor

@doylejd doylejd commented Aug 19, 2015

Resolves issue #35

  • Remove form definitions from AddThis.php and refactor them as Traits.
  • Updated AddThisBlock.php to use the new traits.
  • Updated Field Formatters to use the new traits.
  • Updated Block submit to be more dynamic using the traits.

…on and AddThisBasicToolbox. Updated code where these are used in Block/Field implementations. Removed deprecated code fomr AddThis.php class
@nerdstein
Copy link
Contributor

Missing validation

@nerdstein
Copy link
Contributor

Block and Field forms looking to use Traits

…lass::Method instead of a static validation function
@doylejd
Copy link
Contributor Author

doylejd commented Aug 19, 2015

Resolved validation issues.

nerdstein added a commit that referenced this pull request Aug 20, 2015
Implements Traits for Shared Partial Forms
@nerdstein nerdstein merged commit ddbf2ac into d8-contrib-modules:master Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants