Clean add this element add this wrapper #40
Conversation
|
@ChuChuNaKu - which issue are you referencing? please provide with all PRs |
| ), | ||
| ), | ||
| ); | ||
| //// $element['addthis_basic_toolbox'] = array( |
There was a problem hiding this comment.
Is there a reason why this is commented out? Plan to use later? If not, remove
|
Reviewed and really impressed with how much cleanup occured in this PR, great job. I'll review with more context when I get the issue |
|
@nerdstein sorry about that. This is for issue number #16. I had LOTS of help! |
|
|
||
| return array( | ||
| '#markup' => $markup | ||
| '#type' => 'addthis_basic_toolbox', | ||
| '#size' => $config['basic_toolbox']['buttons_size'], |
There was a problem hiding this comment.
$config does not exist in the context of this function. Blocks use $this->configuration while Fields use $this->getSettings(). You will need to adjust these for the fields.
|
ok, @nerdstein I got rid of the commented code. @doylejd I reworked the fields. |
|
@ChuChuNaKu Going to merge this so Jason can get his stuff working, but I am pretty sure the config arrays are wrong in the field formatters. Lets get a new PR open for that. |
Clean add this element add this wrapper
No description provided.