Implements Tests for AddThis #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it tests for Block, Permissions and Fields
| @@ -56,7 +56,8 @@ public function getServices() { | |||
| '#type' => 'inline_template', | |||
| '#template' => '<span class="addthis_service_icon icon_' . $serviceCode . '"></span> ' . $serviceName, | |||
| ); | |||
| $rows[$serviceCode] = $service; | |||
| //#options expects a string, not an array. Render the element so it becomes a string. | |||
| $rows[$serviceCode] = render($service); | |||
There was a problem hiding this comment.
Hmmm, Controller? It's rendering
There was a problem hiding this comment.
This will be moved as part of another issue. Had to call render() here because of the nature of the nested form options to avoid getting 500 warnings on every load of the admin page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
TODO