Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/25 #53

Merged
merged 3 commits into from
May 24, 2016
Merged

Issues/25 #53

merged 3 commits into from
May 24, 2016

Conversation

pjonckiere
Copy link

  • config is handled by config management in core (AddThisSettingsForm & AddThisSettingsFormAdvanced)
  • the json object was just initialized, thus shouldn’t be stored as a variable
  • getServices() and getServicesJsonUrl() should live in a service
  • fixed some docblocks
  • check_url() is deprecated, so replaced by Html::escape(UrlHelper::stripDangerousProtocols($uri))
  • the AddThis class has no use anymore so can be safely removed
  • in AddThisSettingForm, the $configFactory is stored on it’s parent so there is no need to save another variable with that value

@pjonckiere pjonckiere mentioned this pull request Oct 9, 2015
Open
@doylejd doylejd merged commit 60304d1 into d8-contrib-modules:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjonckiere @doylejd