Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fix: Add various missing headers #233

Merged
merged 2 commits into from
May 18, 2024

Conversation

alarixnia
Copy link
Contributor

No description provided.

@d99kris d99kris self-assigned this May 13, 2024
@d99kris
Copy link
Owner

d99kris commented May 13, 2024

Hi @alarixnia - thanks for contributing. 👍
The PR looks good, I target to merge it in the weekend.

Out of curiosity, for which OS (or compiler) does it fix the build?

@alarixnia
Copy link
Contributor Author

Hi @alarixnia - thanks for contributing. 👍 The PR looks good, I target to merge it in the weekend.

Out of curiosity, for which OS (or compiler) does it fix the build?

Hi, I'm working on a package of nchat for pkgsrc. In pkgsrc we try to support every Unix-like platform, but we have a special focus on NetBSD, Solaris/illumos, Darwin, and Enterprise Linux.

This helps building on NetBSD 10.0 amd64 with GCC 10.

@d99kris
Copy link
Owner

d99kris commented May 15, 2024

Thanks for sharing 👍

@d99kris d99kris changed the base branch from master to build-fix-integration May 18, 2024 01:13
@d99kris d99kris merged commit df49cf4 into d99kris:build-fix-integration May 18, 2024
2 checks passed
@d99kris
Copy link
Owner

d99kris commented May 18, 2024

This has been merged via an integration branch to master now. Thanks again for the contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants