Fix lambda with comment #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrodehl
reviewed
Dec 20, 2022
tests/state/dependencies/modules/defarguments_module1/__init__.py
Outdated
Show resolved
Hide resolved
da-h
force-pushed
the
fix_lambda_with_comment
branch
from
0423491 to
a75af9c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURENAME
This PR fixes another bug regarding the new feature introduced in #121:
Registration of state variables with lambda expression that end with a comment do not work.
Additionally, this PR adds a test case for this bug.
Description
The problem was that the defining source code is parsed by placing them in a dictionary (just as they are defined in code as well).
Internally, the line gets placed in
{and}before compiling it to an ast.New Behavior:
The solution is to simply add line-breaks before placing it in a dictionary-code block (
{,}).Check all before creating this PR: