-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parent autoload #56
Merged
Merged
Parent autoload #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9685f9b
to
16742ae
Compare
171edfa
to
8f2de9a
Compare
8f2de9a
to
99aeabd
Compare
99aeabd
to
7e0434a
Compare
7e0434a
to
5382dde
Compare
sbrodehl
reviewed
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my feedback:
- I think the
register_parents = False
expression seems a little hacky, and without proper documentation might be overlooked. Is there a way to write somethings likemf.register_parents(False)
? - IMHO the link usage for the miniflask package is bad.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Auto-Loading
This PR adds automatic loading of parent modules.
Example
I.e. consider the defined modules:
parent
parent2
parent.level1
parent.level1_second
parent.level1.level2
parent.level1.level2_second
Loading
level2
will now load all modules that are direct parent modules oflevel2
.In this example
mf
will load (in the exact order):parent
parent.level1
parent.level1.level2
Things done in this MR
level1
). now, it will only listparent.level1.level2
, but highlightparent
andlevel1
to show that these are modules themselves.register_parent = False
(globally, as theregister(mf)
function) to disable automatic loading for this module