Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging #98

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Packaging #98

wants to merge 17 commits into from

Conversation

KLimit
Copy link

@KLimit KLimit commented Jun 26, 2023

Restructure for installation as a package (Addresses #87)

Description

  • Implement pyproject.toml
    • dependencies derived from requirements.txt
    • adds an entry point such that pip or pipx can generate a yasb.exe
  • restructure to src layout by moving contents of "src" to "src/yasb"
  • refactor all directory-relative imports to module-relative imports (import core -> from . import core, for example)

Related Issue

Testing

I have successfully installed yasb using pip in a virtual environment (as well as with pipx as alluded to in #87). This was done on a Windows 10 machine. The program can be run by invoking "yasb.exe" (assuming it's on PATH), and still successfully attaches to komorebi, etc.

The bar can live-update from "styles.css"; however, when reloading changes to config.yaml, yasb crashes.
Keeping the PR in draft status until I fix this.

@YisusChrist
Copy link

These changes are a huge improvement in the project design, please keep working on them if you have the time or contact me if you are struggling and need help with something. I think we should all give priority to what has been suggested here by @KLimit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants