-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging #98
Draft
KLimit
wants to merge
17
commits into
da-rth:main
Choose a base branch
from
KLimit:packaging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Packaging #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are a huge improvement in the project design, please keep working on them if you have the time or contact me if you are struggling and need help with something. I think we should all give priority to what has been suggested here by @KLimit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure for installation as a package (Addresses #87)
Description
yasb.exe
import core
->from . import core
, for example)Related Issue
Testing
I have successfully installed yasb using pip in a virtual environment (as well as with pipx as alluded to in #87). This was done on a Windows 10 machine. The program can be run by invoking "yasb.exe" (assuming it's on PATH), and still successfully attaches to komorebi, etc.
The bar can live-update from "styles.css"; however, when reloading changes to config.yaml, yasb crashes.
Keeping the PR in draft status until I fix this.