Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-stack-depth-change): invoke callback only when depth level has changed #430

Merged
merged 3 commits into from
Dec 22, 2023
Merged

feat(plugin-stack-depth-change): invoke callback only when depth level has changed #430

merged 3 commits into from
Dec 22, 2023

Conversation

orionmiz
Copy link
Member

@orionmiz orionmiz commented Dec 22, 2023 •
edited
Loading

For now, stackDepthChangePlugin invokes onDepthChanged callback whenever onChanged hook is called.

Our organization has decided to invoke that callback only when the depth level has changed by some internal requests.

And also, that's what we expect from the name in the plugin.

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Dec 22, 2023 10:42am

@orionmiz orionmiz merged commit a2ecfaf into main Dec 22, 2023
4 checks passed
@orionmiz orionmiz deleted the invoke-callback-by-depth-level branch December 22, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orionmiz