Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, react): @stackflow/react/future #478

Merged
merged 44 commits into from
Jul 31, 2024
Merged

Conversation

tonyfromundefined
Copy link
Member

@tonyfromundefined tonyfromundefined commented Jul 18, 2024

내용

@stackflow/core/future

신규로 추가된 구현을 ./src/future/**/*에 구현했습니다.

To-do

  • 설정 생성 (createConfig())
  • 액티비티 선언 (defineActivity())
  • 액티비티 파라미터 타입 선언 (defineParamsType())
  • config.match(...) 함수 구현

@stackflow/react/future

  • 기존 구현을 ./src/stable/**/*로 옮겼습니다.
  • 다음 버전 API를 ./src/future/**/*에 구현했습니다.
  • loaderPlugin()을 새로 구현했습니다.
  • historySyncPlugin()@stackflow/react/future 내부에 Built-in 했습니다.

To-do

  • 기존 구현 옮기기 (파괴적 변환 없도록)
  • 빌드 설정 변경 (bundle 옵션을 제거)
    • future와 stable 빌드가 따로 되는 경우 React.createContext()가 서로 공유되지 않는다는 것을 알게되었습니다.
    • 따라서 번들링 -> 트랜스파일링으로 변경합니다.
  • 신규 구현
    • stack()
    • flow()
    • stepFlow()

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: e465bf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@stackflow/react Minor
@stackflow/plugin-history-sync Minor
@stackflow/demo Minor
@stackflow/config Minor
@stackflow/docs Patch
@stackflow/compat-await-push Patch
@stackflow/link Patch
@stackflow/plugin-basic-ui Patch
@stackflow/plugin-google-analytics-4 Patch
@stackflow/plugin-map-initial-activity Patch
@stackflow/plugin-preload Patch
@stackflow/plugin-renderer-basic Patch
@stackflow/plugin-renderer-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Jul 31, 2024 9:54am

core/src/future/ActivityDefinition.ts Outdated Show resolved Hide resolved
demo/src/stackflow/stackflow.config.ts Outdated Show resolved Hide resolved
demo/src/activities/Article.tsx Outdated Show resolved Hide resolved
@tonyfromundefined
Copy link
Member Author

🦋 success packages published successfully:
🦋 @stackflow/config@1.0.1-canary.0
🦋 @stackflow/compat-await-push@1.1.11-canary.0
🦋 @stackflow/link@1.4.3-canary.0
🦋 @stackflow/plugin-basic-ui@1.8.3-canary.0
🦋 @stackflow/plugin-google-analytics-4@1.1.13-canary.0
🦋 @stackflow/plugin-history-sync@1.6.0-canary.0
🦋 @stackflow/plugin-map-initial-activity@1.0.9-canary.0
🦋 @stackflow/plugin-preload@1.3.3-canary.0
🦋 @stackflow/plugin-renderer-basic@1.1.11-canary.0
🦋 @stackflow/plugin-renderer-web@1.1.11-canary.0
🦋 @stackflow/react@1.2.0-canary.0

@tonyfromundefined
Copy link
Member Author

한 앱에는 Stackflow 하나만 존재해야하는 제약조건 존재

Copy link
Member

@orionmiz orionmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tonyfromundefined tonyfromundefined merged commit 7df613a into main Jul 31, 2024
4 checks passed
@tonyfromundefined tonyfromundefined deleted the future-api branch July 31, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants