Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-basic-ui): remove will-change property #482

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

orionmiz
Copy link
Member

@orionmiz orionmiz commented Jul 24, 2024

Currently, the element that has will-change property will generate the containing block for the nested fixed element. W3C Spec

To reduce the confusion of using the position: fixed element inside AppScreen and the other utility activities, we decided to remove the all will-change properties used in them.

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 9edd7b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-basic-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Jul 24, 2024 3:30am

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyfromundefined tonyfromundefined merged commit bef6214 into main Jul 24, 2024
4 checks passed
@tonyfromundefined tonyfromundefined deleted the remove-will-change branch July 24, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants