Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(history-sync): add encode interface #535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Nov 15, 2024

  • Add encode interface, counterpart of the existing decode interface
  • Enable usage of encode and decode with Future API

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 5a9b0de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-history-sync Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Nov 16, 2024 6:25am

articleId: String(id),
}),
decode: ({ articleId }) => ({
id: Number(articleId),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty surprised that the decode function can be used to make non-string activity params, which clashes with the assumption of ActivityBaseParams that expects Record<string, string | unknown>. Is it okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant