Add bool dtype support for PLY files #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
reviewed
Jan 3, 2022
| @@ -242,7 +248,7 @@ def describe_element(name, df): | |||
| ------- | |||
| element: list[str] | |||
| """ | |||
| property_formats = {'f': 'float', 'u': 'uchar', 'i': 'int'} | |||
| property_formats = {'f': 'float', 'u': 'uchar', 'i': 'int', 'b': 'bool'} | |||
There was a problem hiding this comment.
Could we add a test for write_ply with bool?
There was a problem hiding this comment.
daavoo
requested changes
Jan 3, 2022
Nicholas-Autio-Mitchell
force-pushed
the
nicholas/bool_support_for_ply
branch
from
5a85c8f to
ba545d4
Compare
|
@daavoo - I've added a test that writes a PLY file containing Boolean data |
Nicholas-Autio-Mitchell
force-pushed
the
nicholas/bool_support_for_ply
branch
from
ba545d4 to
0e1372c
Compare
daavoo
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #309 and adds support for the file reader to deal with Boolean fields (writing boolean fields was already not an issue). It also adds a new test fixture file and a simple unit test.
The new test data PLY file contains the following header:
which loads to give the following dataframe - notice the newly inserted
is_greencolumn of typebool: