Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clarifications regarding setting request header #27

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

matthewhegarty
Copy link
Contributor

I found a couple of gotchas when implementing, so this PR attempts to clarify based on some of the confusion I had.

Also fixed a typo and updated the copyright date.

Feel free to amend / adjust.

@RealOrangeOne RealOrangeOne requested a review from j4mie July 11, 2019 08:41
Copy link
Member

@j4mie j4mie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@RealOrangeOne RealOrangeOne merged commit a891d67 into dabapps:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants