Remove requests.Session passthrough functionality #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaneb
approved these changes
Dec 7, 2021
| @@ -1 +0,0 @@ | |||
| requests<3 | |||
* origin/master: Pass get_response callables to middleware in tests and remove MIDDLEWARE_CLASSES Add Django 4 to test matrix, remove unsupported versions
* origin/master: Document request ID attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the feature that passes the request ID through to outgoing requests using a
requests.Sessionsubclass.Reasoning:
requestslibrary, but other HTTP libraries are emerging e.g. https://www.python-httpx.org/ - should we add functionality todjango-log-request-idfor every one?requests- I have no idea whether it still works for newer versions ofrequests.We'd have to do a major version bump if we decide to merge this.