Skip to content

Commit

Permalink
serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()
Browse files Browse the repository at this point in the history
Use imx_start_tx() just to enable the TX interrupt. It's the job of the
TX interrupt ISR to fill the transmit buffer, then. If the transmit buffer
is empty, the TX interrupt should be executed as soon as the start_tx()
enables the interrupt, so there is no reason for the extra
imx_transmit_buffer() call, here. Remove it.

Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
Signed-off-by: Andy Lowe <andy_lowe@mentor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
dirkbehme authored and gregkh committed Jan 9, 2015
1 parent 7363181 commit 55c3cb1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/tty/serial/imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -621,9 +621,6 @@ static void imx_start_tx(struct uart_port *port)
imx_dma_tx(sport);
return;
}

if (readl(sport->port.membase + uts_reg(sport)) & UTS_TXEMPTY)
imx_transmit_buffer(sport);
}

static irqreturn_t imx_rtsint(int irq, void *dev_id)
Expand Down

0 comments on commit 55c3cb1

Please sign in to comment.