Skip to content

Commit

Permalink
ata: Avoid comma separated statements
Browse files Browse the repository at this point in the history
Use semicolons and braces.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
JoePerches authored and axboe committed Jan 31, 2021
1 parent 10340f8 commit e53d76e
Showing 1 changed file with 13 additions and 8 deletions.
21 changes: 13 additions & 8 deletions drivers/ata/pata_icside.c
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,19 @@ static void pata_icside_set_dmamode(struct ata_port *ap, struct ata_device *adev
* Choose the IOMD cycle timing which ensure that the interface
* satisfies the measured active, recovery and cycle times.
*/
if (t.active <= 50 && t.recover <= 375 && t.cycle <= 425)
iomd_type = 'D', cycle = 187;
else if (t.active <= 125 && t.recover <= 375 && t.cycle <= 500)
iomd_type = 'C', cycle = 250;
else if (t.active <= 200 && t.recover <= 550 && t.cycle <= 750)
iomd_type = 'B', cycle = 437;
else
iomd_type = 'A', cycle = 562;
if (t.active <= 50 && t.recover <= 375 && t.cycle <= 425) {
iomd_type = 'D';
cycle = 187;
} else if (t.active <= 125 && t.recover <= 375 && t.cycle <= 500) {
iomd_type = 'C';
cycle = 250;
} else if (t.active <= 200 && t.recover <= 550 && t.cycle <= 750) {
iomd_type = 'B';
cycle = 437;
} else {
iomd_type = 'A';
cycle = 562;
}

ata_dev_info(adev, "timings: act %dns rec %dns cyc %dns (%c)\n",
t.active, t.recover, t.cycle, iomd_type);
Expand Down

0 comments on commit e53d76e

Please sign in to comment.