Add driver/date-add function necessary to queries with relative date #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodrigodc07 Let me know if this is ready to go, and thanks for adding this! Was just reviewing date support the other day and seemed like it was lacking a bit. |
|
Sorry for the delay, we were testing it, and it's ready to go |
|
Thanks for contribution. We are waiting exactly for this feature =) |
|
I should be able to review and merge this weekend, looks pretty straight-forward! |
|
Looks good to me - I tested with v0.33.4 of Metabase. I had to update my local dependencies, but other than that no issues. Thanks again @rodrigodc07. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.