Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scripts for jar setup, and in-project maven repo #69

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Nov 29, 2020

Thanks for this driver. Great for learning driver development with :)

What I added:

  • replaced user-level maven repo with project-level maven repo (not in version-control)
  • added makefile (inits maven repo, downloads jar, builds)
  • small readme updates

Hopefully make is a universal enough build tool to lean on here. Leiningen seems quite complicated, so I'm not even sure if it has build-tool style stuff, but I added what I knew.

Just scripting some of the stuff you mention in README, so it's executable, and happens all within the git repo dir hierarchy itself. (I don't know much about the java dev ecosystem, but usually try not to mess around with work-around feeling stuff outside my project root, if possible, hence getting it all happening in local files)

Also, seems the leiningen has gotten more strict with needing checksums, as I believe I was getting errors instead of warnings about the checksum being missing. Hence me adding checksum work-around :/

Thanks very much!

@dacort
Copy link
Owner

dacort commented Feb 17, 2021

Hi @patcon!

I apologize profusely for the delay here - I was in the middle of a job transition when this came in.

Thank you SO MUCH for helping automate the build process and making it easier to get the Athena jar into the project. I'm prepping a release, so I hope to get this merged in soon.

If you're still around, I'll let you know if I have any changes needed but at a first glance it looks pretty good. :)

@dacort dacort added this to the v1.2.0 milestone Feb 17, 2021
@patcon
Copy link
Contributor Author

patcon commented Feb 18, 2021

Oh jeez, no sweat, and no rush! 😄 I haven't actually gone all-in with metabase, but still circling around it, and hoping to pull it into a current project in its next phase

This repo was really great to learn with, and I truly appreciate all the work you put into it 🙌

And congrats on the new gig with our Global Overlord of All Human Needs & Desires :)

@dacort
Copy link
Owner

dacort commented Feb 25, 2021

Thanks again for this! Gave it a go locally and it all looks good so merging it in. 🙏

@dacort dacort merged commit 82b71c3 into dacort:master Feb 25, 2021
@patcon patcon deleted the easier-build-prep branch February 26, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants