Update plugin YAML to use new advanced-option plugin fields #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to this change metabase/metabase#19262 in latest version of Metabase the advanced configuration section is not showing up the the add athena database form. This change addresses the relevant YAML field changes to the plugin YAML to show the advanced configutaion section.
|
I had missed this, thanks much for the wonderful PR! Will check it out today to verify and push and new release. |
|
LGTM, thanks again! Will merge and push out a 1.3.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this change metabase/metabase#19262
in the latest version of Metabase, the advanced configuration section is not showing up in the add Athena database dialog.
This PR addresses the relevant YAML field changes to the plugin YAML to show the advanced configuration section.
Kindly suggest changes if any.
Steps to reproduce the issue
With athena.metabase-driver.jar v1.3.0 on metabase v.0.42
With athena.metabase-driver.jar built on this branch on metabase v.0.42