Fix warnings in CI #226
Merged
Fix warnings in CI #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dada-lang ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Do you mean such warnings?
|
Yes, exactly |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 14, 2023
226: Fix warnings in CI r=Aadamandersson a=Aadamandersson This fixes the warnings in our CI. We are currently using [action-rs/toolchain](https://github.com/actions-rs/toolchain) to install the Rust toolchain in Github Actions. But as it seems to be unmaintained (see actions-rs/toolchain#216) and needs to be replaced to fix some of the warnings (see actions-rs/toolchain#219) I have replaced it with [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain), which looks like a suitable replacement. Co-authored-by: Adam Andersson <adam.m.andersson@gmail.com>
|
Timed out. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 14, 2023
226: Fix warnings in CI r=Aadamandersson a=Aadamandersson This fixes the warnings in our CI. We are currently using [action-rs/toolchain](https://github.com/actions-rs/toolchain) to install the Rust toolchain in Github Actions. But as it seems to be unmaintained (see actions-rs/toolchain#216) and needs to be replaced to fix some of the warnings (see actions-rs/toolchain#219) I have replaced it with [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain), which looks like a suitable replacement. Co-authored-by: Adam Andersson <adam.m.andersson@gmail.com>
|
Timed out. |
|
This needs a Lines 2 to 6 in 22da3d6 |
|
Oh, I see. Thanks! |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warnings in our CI.
We are currently using action-rs/toolchain to install the Rust toolchain in Github Actions. But as it seems to be unmaintained (see actions-rs/toolchain#216) and needs to be replaced to fix some of the warnings (see actions-rs/toolchain#219) I have replaced it with dtolnay/rust-toolchain, which looks like a suitable replacement.