-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format_phone for mexico numbers are not prefixing properly on v0.6.29 #152
Comments
@agustindaguerre Hi, this gem is based on google's libphonenumber, they are saying national number should look with space after "01", you can check it here |
@daddyz you're right on that one. I'm seeing this issue with phones like |
@agustindaguerre fixed this in master branch currently, will make another release soon |
@agustindaguerre just released v0.6.36 |
After updating from 0.6.28 to 0.6.29 format_phone for Mexico numbers changed the prefixing by splitting the first 5 numbers with a space after the second number.
Test failing:
format_phone("+529841234567")
This change shouldn't have been released as a patch but as a minor version update
The text was updated successfully, but these errors were encountered: