Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_phone for mexico numbers are not prefixing properly on v0.6.29 #152

Closed
agustindaguerre opened this issue Feb 22, 2019 · 4 comments
Closed

Comments

@agustindaguerre
Copy link

agustindaguerre commented Feb 22, 2019

After updating from 0.6.28 to 0.6.29 format_phone for Mexico numbers changed the prefixing by splitting the first 5 numbers with a space after the second number.

Test failing:
format_phone("+529841234567")

expected: "01984 123 4567"
got: "01 984 123 4567"

This change shouldn't have been released as a patch but as a minor version update

@daddyz
Copy link
Owner

daddyz commented Mar 6, 2019

@agustindaguerre Hi, this gem is based on google's libphonenumber, they are saying national number should look with space after "01", you can check it here

@agustindaguerre
Copy link
Author

@daddyz you're right on that one. I'm seeing this issue with phones like 0459991234567, this one national number format should be 044 999 123 4567 but I'm getting 999 123 4567 instead. Do you have any idea what may be causing this issue?

@daddyz
Copy link
Owner

daddyz commented Jun 10, 2019

@agustindaguerre fixed this in master branch currently, will make another release soon

@daddyz
Copy link
Owner

daddyz commented Jun 17, 2019

@agustindaguerre just released v0.6.36

@daddyz daddyz closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants