For_Func_returned_type_with_lazy_dependency_Func_parameters_are_correctly_passed

[wgebczyk]

Hi,

This quick fix attempts to fix mistake when processing lambda parameters and trying to take it from parent expression.
If there is assumption that ParamExprs.Length == ParamValues.Length, this change aligns code to the intention.

I've tried to make most simple unit test that is reusing as much as possible of existing types.

Another, standalone PoC of the issue can be found here:

public class Dep1 { }
public class Dep2 { }
public class Dep3 { }
public class Dep4 { }

public class Dep5
{
    public void Run() => Console.WriteLine("Dep5.Run()");
}

public class Dep6
{
    private readonly Lazy<Dep5> _dep5;

    public Dep6(Dep1 dep1, Dep2 dep2, Dep3 dep3, Dep4 dep4, Lazy<Dep5> dep5)
    {
        _dep5 = dep5;
    }

    public void Run()
    {
        Console.WriteLine("Dep6.Run() => Dep5.Run()");
        _dep5.Value.Run();
    }
}

static class Program
{
    static void Main()
    {
        var container = new Container();

        container.Register<Dep1>();
        container.Register<Dep2>();
        container.Register<Dep3>();
        container.Register<Dep4>();
        container.Register<Dep5>();
        container.Register<Dep6>();

        var funcDep6 = container.Resolve<Func<Dep1, Dep2, Dep6>>();
        var dep6 = funcDep6(new Dep1(), new Dep2());
        dep6.Run();
    }
}

[dadhi]

@wgebczyk Thank you, will look a bit later.

[dadhi]

@wgebczyk This is just an amazing pinpoint finding and the fix. Merging now.

[dadhi]

@wgebczyk The version 4.7.6 with your fix is out.

[wgebczyk]

That's amazing quick PR review, approval and releasing of the fix :D

Thank you!

[piotrandrzejewski1]

@dadhi Amazing job!