DB connection recovery (and more!) #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR:
DELETE
method throws a 404 (instead of 204) when deleting a non-existing document by ID. This applies to requests where the document ID is passed in the URL, not when in the body (e.g.DELETE /v1/db/collection/DOC-ID
vsDELETE /v1/db/collection
) (DELETE should return 404 when no documents match the supplied query #345)POST
/PUT
methods throw a 404 when updating a non-existing document by ID. This applies to requests where the document ID is passed in the URL, not when in the body (e.g.PUT /v1/db/collection/DOC-ID
vsPUT /v1/db/collection
)Tests:
API boots with database unavailable and recovers when it reconnects
API boots with database available and recovers from subsequent failures
RESTful
DELETE
on non-existing documents returns a 404RESTful
POST
/PUT
on non-existing documents return a 404