Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Editor: Formatting lost #607

Closed
davidmacp opened this issue Nov 21, 2018 · 5 comments
Closed

Rich Editor: Formatting lost #607

davidmacp opened this issue Nov 21, 2018 · 5 comments

Comments

@davidmacp
Copy link
Contributor

Expected behavior

User creates and saves document using Rich Editor features/formatting. When accessing/editing the document again the formatting of text is retained.

Actual behavior

User creates and saves document using Rich Editor features/formatting. When accessing/editing the document again the formatting of text has been lost.

On saving:
screen shot 2018-11-22 at 10 37 05 am

On exiting and then selecting to edit:
screen shot 2018-11-22 at 10 37 58 am

Steps to reproduce the problem

  1. Navigate to http://publish-develop.eb.dev.dadi.technology/articles/new
  2. Enter data into rich editor with formatting (Bold, Underline etc)
  3. Save article and go back to article list
  4. Select article to edit

Package details

1.0.14-beta

@davidmacp
Copy link
Contributor Author

@eduardoboucas have been testing the link in the PR #608

Some observations:

Create an article with some rich text and save - get the following:
screen shot 2018-11-23 at 10 57 46 am

Exit article then select from article list again gets:
screen shot 2018-11-23 at 10 58 50 am

With this error:
screen shot 2018-11-23 at 10 59 00 am

Ordered/Unordered lists - create and save gives:
screen shot 2018-11-23 at 11 03 08 am

Exit article then select from article list again gets:
screen shot 2018-11-23 at 11 03 52 am

Toggle code button - press code button, enter text, hit enter.
screen shot 2018-11-23 at 11 20 01 am

Click code button again to toggle off - text is cleared as below:
screen shot 2018-11-23 at 11 20 23 am

@eduardoboucas
Copy link
Contributor

Thanks for the feedback, @davidmacp. Here's the current state of things.

Create an article with some rich text and save - get the following:
Exit article then select from article list again gets:

If I understand correctly, the only problem here was that the underline formatting was being lost when saving. This was actually an oversight from us, because there is no support for underline in Markdown so the button shouldn't even be there. I have removed it in #608.

With this error:

I wasn't able to replicate this. Could you provide more info on how to trigger the error?

Ordered/Unordered lists - create and save gives:
Exit article then select from article list again gets:

This is a known issue, captured in #561.

Toggle code button - press code button, enter text, hit enter.
Click code button again to toggle off - text is cleared as below:

I have created a new issue for this: #620.

@eduardoboucas
Copy link
Contributor

@davidmacp Based on the message above, can you please test all the cases on develop and re-open this ticket if any of the problems persist? Thanks!

@davidmacp
Copy link
Contributor Author

@eduardoboucas ^ the lists one - I can see the known issue as you have referenced. Does this also affect the fact that bullet (unordered) points get changed to numbered (ordered) lists after saving, exiting, then going in to edit again?

Create numbered list followed by bullet list, then Save and go back
screen shot 2018-11-27 at 11 04 29 am

Select article to edit:
screen shot 2018-11-27 at 11 06 27 am

Switch to markdown view:
screen shot 2018-11-27 at 11 06 38 am

@eduardoboucas
Copy link
Contributor

The problem you're seeing is that contiguous lists in Markdown are merged into one. That is part of the spec. If you change your test case to include some non-list text in between the ordered and unordered lists, it should behave as expected.

If not, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants