Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Editor: issues with Return key on code blocks #620

Closed
eduardoboucas opened this issue Nov 26, 2018 · 3 comments · Fixed by #621
Closed

Rich Editor: issues with Return key on code blocks #620

eduardoboucas opened this issue Nov 26, 2018 · 3 comments · Fixed by #621

Comments

@eduardoboucas
Copy link
Contributor

Expected behavior

When the user presses Return inside a code block, a new line is inserted within the code block.

Actual behavior

When the user presses Return inside a code block, a new block is created.

Steps to reproduce the problem

Create a code block, type some text and press Return. Observe a new code block being created.

Package details

1.0.16-beta

@eduardoboucas
Copy link
Contributor Author

@davidmacp Can you test this on develop and reopen if still an issue?

@davidmacp
Copy link
Contributor

@eduardoboucas still having issues with this in develop

If I toggle the Code button ON then type in text
screen shot 2018-11-27 at 8 58 25 am

When I toggle the Code button OFF to complete then the following error is seen and the text disappears
screen shot 2018-11-27 at 8 58 49 am

However, switching to markdown view I can see the 'code text' there
screen shot 2018-11-27 at 8 59 10 am

@eduardoboucas
Copy link
Contributor Author

Confirmed. Will sort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants