Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrige r/b para r/o #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Corrige r/b para r/o #8

wants to merge 2 commits into from

Conversation

joellensilva
Copy link
Contributor

Corrigindo algumas rubricas que eram adicionadas erroneamente como R/B

JezzDiego
JezzDiego approved these changes Dec 9, 2024
View reviewed changes
Copy link

@JezzDiego JezzDiego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que é bom documentar o motivo de especificamente no value == 4 ser B e não O

fonluiz
fonluiz approved these changes Dec 10, 2024
View reviewed changes
Copy link

@fonluiz fonluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bom trabalho, Joellen! Deixo uma sugestão para adicionar comentários ao longo do script explicando a lógica do negócio (como o Jessé comentou).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JezzDiego JezzDiego JezzDiego approved these changes

@fonluiz fonluiz fonluiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joellensilva @fonluiz @JezzDiego