Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dae): refine configFile type #106

Merged
merged 1 commit into from
Sep 23, 2024
Merged

chore(dae): refine configFile type #106

merged 1 commit into from
Sep 23, 2024

Conversation

oluceps
Copy link
Contributor

@oluceps oluceps commented Sep 21, 2024

close #105
Not affect the existing config.

@oluceps oluceps requested review from a team as code owners September 21, 2024 14:25
@dae-prow dae-prow bot added the chore label Sep 21, 2024
@oluceps oluceps marked this pull request as draft September 21, 2024 14:26
@oluceps oluceps force-pushed the cfgfile-type branch 3 times, most recently from 56f2272 to a9733f3 Compare September 21, 2024 14:31
@oluceps
Copy link
Contributor Author

oluceps commented Sep 21, 2024

close #103

@oluceps oluceps marked this pull request as ready for review September 21, 2024 14:36
@oluceps oluceps linked an issue Sep 21, 2024 that may be closed by this pull request
@oluceps oluceps added the enhancement New feature or request label Sep 22, 2024
@oluceps oluceps merged commit 68e469f into main Sep 23, 2024
7 checks passed
@oluceps oluceps deleted the cfgfile-type branch September 23, 2024 04:52
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
sumire88 pushed a commit that referenced this pull request Sep 23, 2024
Co-authored-by: oluceps <i@oluceps.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type check for dae configFile permissions are too open
2 participants