Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance module #20

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Enhance module #20

merged 5 commits into from
Mar 14, 2024

Conversation

oluceps
Copy link
Contributor

@oluceps oluceps commented Mar 14, 2024

Include: NixOS/nixpkgs#265270

Now be able to auto reload dae while using config (corresponding to configFile) option after rebuilding the system. But this's not recommended since it will expose the config file in nix store with global readable.

oluceps added 2 commits March 14, 2024 18:30
add reloadTriggers
optional create file in etc
fix assetsPath defaultText
* remove `mdDoc` since which is default.
* no longer override `/etc/dae/config.dae` while `configPath`  set.
@oluceps oluceps requested review from a team as code owners March 14, 2024 11:16
sumire88
sumire88 previously approved these changes Mar 14, 2024
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After merging this PR, would you like to also cherry-pick this the merge commit into the unstable and exp branches?

oluceps added 3 commits March 14, 2024 20:38
Flake lock file updates:

• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/b253292d9c0a5ead9bc98c4e9a26c6312e27d69f' (2024-02-01)
  → 'github:hercules-ci/flake-parts/f7b3c975cf067e56e7cda6cb098ebe3fb4d74ca2' (2024-03-01)
• Updated input 'flake-parts/nixpkgs-lib':
    'github:NixOS/nixpkgs/97b17f32362e475016f942bbdfda4a4a72a8a652?dir=lib' (2024-01-29)
  → 'github:NixOS/nixpkgs/1536926ef5621b09bba54035ae2bb6d806d72ac8?dir=lib' (2024-02-29)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/b8b232ae7b8b144397fdb12d20f592e5e7c1a64d' (2024-01-31)
  → 'github:NixOS/nixpkgs/0ad13a6833440b8e238947e47bea7f11071dc2b2' (2024-03-12)
• Updated input 'pre-commit-hooks':
    'github:cachix/pre-commit-hooks.nix/7c54e08a689b53c8a1e5d70169f2ec9e2a68ffaf' (2024-01-28)
  → 'github:cachix/pre-commit-hooks.nix/5df5a70ad7575f6601d91f0efec95dd9bc619431' (2024-02-15)
@oluceps
Copy link
Contributor Author

oluceps commented Mar 14, 2024

also cherry-pick this the merge commit into the unstable and exp branches

Done.

@oluceps oluceps requested a review from sumire88 March 14, 2024 12:46
@oluceps oluceps merged commit e1a6691 into main Mar 14, 2024
2 checks passed
@oluceps oluceps deleted the enhance-module branch March 14, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants