Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #2444 #2781

Closed
robin-aws opened this issue Sep 21, 2022 · 0 comments · Fixed by #2786
Closed

Revert #2444 #2781

robin-aws opened this issue Sep 21, 2022 · 0 comments · Fixed by #2786
Labels
release-blocker Must be resolved before the next release

Comments

@robin-aws
Copy link
Member

See #2444
@robin-aws robin-aws added the release-blocker Must be resolved before the next release label Sep 21, 2022
@cpitclaudel cpitclaudel mentioned this issue Sep 22, 2022
Merged
cpitclaudel added a commit that referenced this issue Sep 22, 2022
@cpitclaudel
Revert "feat: Add #nullable disable to generated C# code to avoid war…
2bc0042 
…nings (#2444)" (#2786)

This reverts commit ecd825e.

The `#nullable enable` annotation is a recent C# feature, so that commit
broke compatibility with some client code.

Fixes #2781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-blocker Must be resolved before the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "feat: Add #nullable disable to generated C# code to avoid warnings (#2444)" dafny-lang/dafny
1 participant
@robin-aws