Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to options for dafny resolve #3218

Closed
davidcok opened this issue Dec 19, 2022 · 3 comments · Fixed by #3227
Closed

Adjustments to options for dafny resolve #3218

davidcok opened this issue Dec 19, 2022 · 3 comments · Fixed by #3227
Assignees
Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny

Comments

@davidcok
Copy link
Collaborator

davidcok commented Dec 19, 2022

Summary

The current options for dafny resolve are not all appropriate. Here are suggested changes.

Background and Motivation

The options for each command in the new CLI are in flux (and will be based on user needs as well). But some current ones are inappropriate.

Proposed Feature

Remove these options from dafny resolve:

--boogie (just for --verify and other commands that do verification)

--disable-nonlinear-arithmetic (just for --verify and other commands that do verification)

--relax-definite-assignment (just for --verify and other commands that do verification)

--plugin (only applies in legacy mode at present)

Perhaps the default for the following should be true in the new CLI
--warn-missing-constructor-parentheses Emits a warning when a constructor
name in a case pattern is not
followed by parentheses.
Also

--unicode-char needs a default stated

Alternatives

No response

@davidcok davidcok added the kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny label Dec 19, 2022
@keyboardDrummer
Copy link
Member

keyboardDrummer commented Dec 20, 2022

Why wouldn't you expect --plugin for dafny resolve ? Plugins can effect resolution behavior.

@keyboardDrummer
Copy link
Member

keyboardDrummer commented Dec 20, 2022

#3227 resolves most of this except the defaults for warnings.

keyboardDrummer added a commit that referenced this issue Dec 20, 2022
Fixes #3218

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
@davidcok
Copy link
Collaborator Author

I was thinking of --plugin as a standalone tool, like audit or doc. But you are right. They could just change some functionality for a phase of the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants