Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative load option in new CLI #3328

Closed
hmijail opened this issue Jan 5, 2023 · 0 comments · Fixed by #3357
Closed

Relative load option in new CLI #3328

hmijail opened this issue Jan 5, 2023 · 0 comments · Fixed by #3357
Assignees
@keyboardDrummer
Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny part: CLI interacting with Dafny on the command line

Comments

@hmijail
Copy link

hmijail commented Jan 5, 2023

Summary

The legacy CLI had the /vcsLoad argument, which allowed to specify a multiplier on the number of detected cores. This made things rather self-adjusting across systems.

The new CLI seems to only have --cores to specify the absolute number of cores to use. This requires more hand-holding.

Background and Motivation

Dev machines typically have very different specs to cloud CI runners. It's important to accommodate the verifying/build process to each case.

Proposed Feature

Keep some way to automatically adjust the load depending on the system. /vcsLoad was coarse, but might be good enough.

Alternatives

No response
@hmijail hmijail added the kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny label Jan 5, 2023
@MikaelMayer MikaelMayer added the part: CLI interacting with Dafny on the command line label Jan 5, 2023
@keyboardDrummer keyboardDrummer mentioned this issue Jan 12, 2023
Merged
keyboardDrummer added a commit that referenced this issue Jan 17, 2023
@keyboardDrummer
Enable passing a percentage as a value for --cores (#3357)
bcf4042 
Fixes #3328

```
  --cores <count>                         Run the Dafny CLI using <n> cores, or using 
                                          <XX%> of the machine's logical cores. 
                                          [default: 6]
```

Default is 50% of logical cores. Sadly the help shows that number
already being resolved. Changing that is complicated.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
davidcok pushed a commit to davidcok/dafny that referenced this issue Jan 18, 2023
@keyboardDrummer
Enable passing a percentage as a value for --cores (dafny-lang#3357)
b42d275 
Fixes dafny-lang#3328

```
  --cores <count>                         Run the Dafny CLI using <n> cores, or using 
                                          <XX%> of the machine's logical cores. 
                                          [default: 6]
```

Default is 50% of logical cores. Sadly the help shows that number
already being resolved. Changing that is complicated.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
davidcok pushed a commit to davidcok/dafny that referenced this issue Jan 20, 2023
@keyboardDrummer
Enable passing a percentage as a value for --cores (dafny-lang#3357)
a19f44c 
Fixes dafny-lang#3328

```
  --cores <count>                         Run the Dafny CLI using <n> cores, or using 
                                          <XX%> of the machine's logical cores. 
                                          [default: 6]
```

Default is 50% of logical cores. Sadly the help shows that number
already being resolved. Changing that is complicated.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keyboardDrummer keyboardDrummer

Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny part: CLI interacting with Dafny on the command line
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable passing a percentage as a value for --cores keyboardDrummer/dafny
3 participants
@keyboardDrummer @MikaelMayer @hmijail