fix: Don’t entirely delete by-method part in export scope checks #1855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the by-method part of a function-by-method was entirely erased in the module clone used to perform export-set consistency checks. That was incorrect. The by-method part should be erased only if the function-by-method is export-provided. If the function-by-method is export-revealed, then the appropriate thing to do for the clone is to remove the contents of the by-method body, but still keep the empty body around so that the function still looks like a function-by-method.
Fixes #1852