Bounded pool for not in #1939
Merged
Bounded pool for not in #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
requested changes
Mar 29, 2022
| @@ -3313,7 +3313,8 @@ public class CheckHasNoAssumes_Visitor : BottomUpVisitor { | |||
| } else if (bound is ComprehensionExpr.MapBoundedPool) { | |||
| var b = (ComprehensionExpr.MapBoundedPool)bound; | |||
| TrParenExpr(su.Substitute(b.Map), collectionWriter, inLetExprBody); | |||
| collectionWriter.Write(".Keys{0}.Elements{0}", propertySuffix); | |||
| GetSpecialFieldInfo(SpecialField.ID.Keys, null, null, out var keyName, out _, out _); | |||
There was a problem hiding this comment.
Could you please add a test that explain why this change was necessary?
There was a problem hiding this comment.
Method PrintCollectionEmptiness in Test/comp/Comprehensions.dfy includes tests that previously failed with Java. Previously, the code on L3316 would output .Keys.Elements (or .Keys().Elements()) for all the compilers. However, in Java, our compiler uses the name .keySet() instead of .Keys. The GetSpecialFieldInfo mechanism returns the appropriate name for each language.
|
@MikaelMayer The tests in method |
# Conflicts: # RELEASE_NOTES.md # Source/Dafny/Compilers/SinglePassCompiler.cs
# Conflicts: # RELEASE_NOTES.md
MikaelMayer
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize
!inoperator when looking for compilable comprehensions. For example, each of the quantificationscompiled, but the equivalent
did not. Now, all of them compile.
Also, fix malformed Java code generated for comprehensions that use maps.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.